Make published macOS wheels portable #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proposed fix for #79 |
devinrsmith
force-pushed
the
mac-dylib-fix
branch
from
0fe3150 to
5af62a1
Compare
devinrsmith
force-pushed
the
mac-dylib-fix
branch
from
5af62a1 to
425fea8
Compare
devinrsmith
changed the title
This has the effect of removing the non-portable LC_LOAD_DYLIB and LC_RPATH directives for libjvm.dylib from the .so file. Fixes jpy-consortium#79, see for more details
devinrsmith
changed the title
devinrsmith
force-pushed
the
mac-dylib-fix
branch
from
425fea8 to
22fa89b
Compare
|
#80 has been added as a follow-up issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.