Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

free threaded build #1224

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

astrelsky
Copy link
Contributor

@astrelsky astrelsky commented Oct 11, 2024

As far as I can tell, jpype is already thread safe as it was necessary since Java is a normal programming that isn't scared of more than one thread.

Anyone looking to use the experimental free threaded build of python should be anticipating to encounter some, uh, problems anyway. problem example

@marscher I'm a complete dinosaur when it comes to ci/cd stuff so I didn't touch any of it. In order to build the free threaded version on windows I needed to do python3.13t -m pip install -e ., so I'm assuming it's a similar situation with the other operating systems.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.20%. Comparing base (6b89751) to head (62f48c5).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
native/python/jp_pythontypes.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1224   +/-   ##
=======================================
  Coverage   87.20%   87.20%           
=======================================
  Files         113      113           
  Lines       10296    10296           
  Branches     4076     4076           
=======================================
  Hits         8979     8979           
  Misses        722      722           
  Partials      595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marscher
Copy link
Member

Thanks for this interesting contribution. Is the thread-free branch enabled by default when using Python 3.13 or how is toggled?

@astrelsky
Copy link
Contributor Author

astrelsky commented Oct 15, 2024

Thanks for this interesting contribution. Is the thread-free branch enabled by default when using Python 3.13 or how is toggled?

It is disabled by default. You must explicitly run it via python3.13t. It is available as an option in the windows and mac python installers. I don't see any information about Linux on the documentation page at https://docs.python.org/3/howto/free-threading-python.html I assume it would depend on the Linux variant and it's package manager for the free threaded build without having to build it yourself.

It took me about 8 edits to get that link right. It didn't occur to me that my phone stuck in the space in howto automatically

Copy link
Contributor

@Thrameos Thrameos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thrameos Thrameos merged commit 1dca470 into jpype-project:master Nov 5, 2024
23 of 27 checks passed
@astrelsky
Copy link
Contributor Author

LGTM

Thank you

@astrelsky astrelsky deleted the free_threaded branch November 5, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants