Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indices reports byte offsets instead of character offsets #3064

Closed
01mf02 opened this issue Mar 12, 2024 · 1 comment · Fixed by #3065
Closed

indices reports byte offsets instead of character offsets #3064

01mf02 opened this issue Mar 12, 2024 · 1 comment · Fixed by #3065
Labels

Comments

@01mf02
Copy link

01mf02 commented Mar 12, 2024

Describe the bug
jq uses characters to index strings.
To see that, we can run "🇬🇧oo" | .[0 : 1,2,3,4], which yields "🇬" "🇬🇧" "🇬🇧o" "🇬🇧oo".
Note that 🇬🇧 is actually two characters and 8 bytes, as we can see from "🇬🇧" | length, utf8bytelength.
However, the indices filter returns byte offsets to the pattern in the string.
The documentation does not specify the behaviour of indices for UTF-8 strings, but given that length and .[x:y] use character counts to index strings, it is likely that this is a bug and not just undocumented behaviour.

To Reproduce
$ ./jq-linux-amd64-1.7.1 -nc '"🇬🇧oo" | indices("o")'
[8,9]
$ ./jq-linux-amd64-1.7.1 -nc '"ƒoo" | indices("o")'
[2,3]

Expected behavior
$ ./jq-linux-amd64-1.7.1-fixed -nc '"🇬🇧oo" | indices("o")'
[2,3]
$ ./jq-linux-amd64-1.7.1-fixed -nc '"ƒoo" | indices("o")'
[1,2]

The problem is probably caused in jv_string_indexes.

@itchyny
Copy link
Contributor

itchyny commented Mar 12, 2024

This is a dup of #1430, #1624.

wader added a commit to wader/jq that referenced this issue Mar 12, 2024
@emanuele6 emanuele6 added the dup label Mar 15, 2024
wader added a commit that referenced this issue Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants