Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for seccomp #1215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mark-kubacki
Copy link
Contributor

@mark-kubacki mark-kubacki commented Aug 19, 2016

Seccomp results in Linux sandboxing jq, which will make bugs harder to exploit.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.333% when pulling e9efc0a on wmark:seccomp into 0b82185 on stedolan:master.

@mark-kubacki
Copy link
Contributor Author

We've used jq plenty with this patch in, and didn't encounter any issues.

@nicowilliams
Copy link
Contributor

What a strange Travis CI failure...

@mark-kubacki
Copy link
Contributor Author

mark-kubacki commented Aug 4, 2017

Rebased. Tested with glibc 2.25 and 2.26.

Travis doesn't ship with libseccomp-dev. The errors are not mine.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 80.272% when pulling 1b310de on wmark:seccomp into 7b81a83 on stedolan:master.

Seccomp makes bugs in jq harder to exploit by imposing limits on the
behaviour of the binary. On transgressions the Linux kernel will kill
it, and print "Bad system call" (or similar). (The kernel's audit log
will contain more details.)

This patch comes with a prelimiary ruleset. That is, I might have missed
some legal syscalls.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 80.272% when pulling 1967036 on wmark:seccomp into 7b81a83 on stedolan:master.

@mark-kubacki
Copy link
Contributor Author

Anything I can do to move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants