-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for seccomp #1215
Open
mark-kubacki
wants to merge
1
commit into
jqlang:master
Choose a base branch
from
mark-kubacki:seccomp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for seccomp #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've used jq plenty with this patch in, and didn't encounter any issues. |
What a strange Travis CI failure... |
Rebased. Tested with glibc 2.25 and 2.26. Travis doesn't ship with |
Seccomp makes bugs in jq harder to exploit by imposing limits on the behaviour of the binary. On transgressions the Linux kernel will kill it, and print "Bad system call" (or similar). (The kernel's audit log will contain more details.) This patch comes with a prelimiary ruleset. That is, I might have missed some legal syscalls.
Anything I can do to move this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seccomp results in Linux sandboxing jq, which will make bugs harder to exploit.