wip: feat: terminate jq immediately after the outgoing pipe closed #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicowilliams
reviewed
Jul 7, 2023
| { | ||
| #ifndef WIN32 | ||
| signal(SIGPIPE, SIG_IGN); | ||
| fprintf(stderr, "jq: error: received SIGPIPE\n"); |
There was a problem hiding this comment.
fprintf is not async-signal-safe, so it can't be used from a signal handler.
nicowilliams
reviewed
Jul 7, 2023
| #ifndef WIN32 | ||
| signal(SIGPIPE, SIG_IGN); | ||
| fprintf(stderr, "jq: error: received SIGPIPE\n"); | ||
| exit(128 + SIGPIPE); |
There was a problem hiding this comment.
exit() is not async-signal-safe, so it can't be used from a signal handler. Use _exit() instead.
There was a problem hiding this comment.
If and when we add an FFI this (exiting in a signal handler) will probably not be a safe thing to do.
|
See also commentary in #1285. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work. In reality, this does compile, but doesn't function when I actually try to emit SIGPIPE by doing:
My understanding is that the missing command
fooshould immediately result in SIGPIPE on the jq command, so thatthis feature terminates jq immediately.
I'd greatly appreciate it if anyone could share your insight on how I could make it actually work 🙏
Resolves #1691