Fix iterration problem for non decimal string #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes Issue #2406 |
When the string transformation to number failed, all following transformation failed too. This happend because status in decNumberFromString function is updated just in error case. Reusing the DEC_CONTEXT that failed before results into error even if the string is valid number.
|
I force pushed small change. Using is probably better than |
|
Fixes issue #2400 too. |
|
Thank you!!! |
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the string transformation to number failed, all following
transformation failed too.
This happened because the status in decNumberFromString function is
updated just in case of error. See the line
Reusing the DEC_CONTEXT that failed before results into error even if the string is valid number.
I realize that this is not good solution. This PR is meant more to start the discussion on how to fix the issue correctly. I'm not familiar with the jq code.
With this patch all tests works. So maybe just making decStatus() available and calling it here would be good enough. Maybe setting the status to 0 at the beginning of decNumberFromString()?
What do you think?