Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify split behavior #2462

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

ltrzesniewski
Copy link
Contributor

Hi there 👋

I just read the docs, and made this PR which clarifies how split works, as the initial description left me puzzled.

Also note that I initially forked this repo to fix what cc4efc4 already did, so the web manual is outdated.

@wader
Copy link
Member

wader commented Aug 7, 2022

LGTM, maybe should have a similar reverse comment for split(str)?

@ltrzesniewski
Copy link
Contributor Author

Sure, why not, I added a comment there.

Copy link
Contributor

@itchyny itchyny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@itchyny itchyny merged commit b7f9587 into jqlang:master Jun 5, 2023
@ltrzesniewski ltrzesniewski deleted the docs-clarify-split branch June 6, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants