Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign website #2628

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Redesign website #2628

merged 1 commit into from
Jul 31, 2023

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Jun 24, 2023 •
edited
Loading

This PR improves the jq website entirely.

  • Bump up Bootstrap to v5.3.0, Bootstrap Icon to v1.10.5.
  • Use autoComplete.js to drop dependency on jQuery, typeahead.js.
  • Support dark mode.
  • New svg logo and icon with responsive color mode support.
  • Improve section ids to make them easy to link in Markdown.
  • Various markup cleanups and accessibility improvements.

Resolves #986, resolves #1714, resolves #1848, resolves #2419, resolves #2555.

Screenshots

Color mode light dark
Top page Screenshot 2023-06-24 at 12 41 51 Screenshot 2023-06-24 at 12 41 55
Tutorial Screenshot 2023-06-24 at 12 42 08 Screenshot 2023-06-24 at 12 42 11
Download Screenshot 2023-06-24 at 12 42 19 Screenshot 2023-06-24 at 12 42 23
Manual Screenshot 2023-06-24 at 12 42 35 Screenshot 2023-06-24 at 12 42 39
Manual search Screenshot 2023-06-24 at 12 43 04 Screenshot 2023-06-24 at 12 43 10
Manual examples Screenshot 2023-06-24 at 12 44 03 Screenshot 2023-06-24 at 12 44 07
Responsive global navigator Screenshot 2023-06-24 at 12 44 41 Screenshot 2023-06-24 at 12 44 45
Responsive table of contents Screenshot 2023-06-24 at 12 44 56 Screenshot 2023-06-24 at 12 45 01

@itchyny itchyny added the docs label Jun 24, 2023
@itchyny itchyny force-pushed the redesign-website branch 2 times, most recently from 6dfa101 to 92bd503 Compare June 24, 2023 07:38
wader
wader approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@wader wader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed diff and look good think 👍 do you want me to generate the site locally and play around a bit?

@itchyny itchyny mentioned this pull request Jun 25, 2023
Closed
@itchyny itchyny added this to the 1.7 release milestone Jun 25, 2023
@itchyny itchyny mentioned this pull request Jul 10, 2023
Closed
@nicowilliams
Copy link
Contributor

Is this PR waiting on a review?

@nicowilliams
Copy link
Contributor

LGTM, but you have to rebase.

@itchyny itchyny marked this pull request as draft July 13, 2023 14:59
@nicowilliams
Copy link
Contributor

Do we want to merge this before or after the 1.7 release?

@itchyny
Redesign website
28b1ee8 
* Bump up Bootstrap to v5.3.1, Bootstrap Icon to v1.10.5.
* Use autoComplete.js to drop dependency on jQuery and typeahead.js.
* Support dark mode.
* New svg logo and icon with responsive color mode support.
* Normalize section ids to lower kebab-case for easiness of linking.
* Use relative paths for links for local development (--root /output).
* Various markup cleanups and accessibility improvements.
@nicowilliams
Copy link
Contributor

Should this still be a draft PR, @itchyny, or is it ready?

@itchyny
Copy link
Contributor Author

itchyny commented Jul 31, 2023

I'll include this now, thank you.

@itchyny itchyny marked this pull request as ready for review July 31, 2023 00:51
@itchyny itchyny merged commit c8e28da into jqlang:master Jul 31, 2023
29 checks passed
@nicowilliams
Copy link
Contributor

This is beautiful. Thank you!

@itchyny itchyny mentioned this pull request Jul 31, 2023
Closed
pkoppstein added a commit to pkoppstein/jq that referenced this pull request Jul 31, 2023
@pkoppstein
Squashed commit of the following:
174fd86 
commit 9afda0a
Merge: 4665e81 eeb08b5
Author: pkoppstein <pkoppstein@gmail.com>
Date:   Mon Jul 31 07:33:58 2023 -0400

    Merge branch 'walk' of https://github.com/pkoppstein/jq into walk

commit 4665e81
Author: pkoppstein <pkoppstein@gmail.com>
Date:   Mon Jul 31 07:26:03 2023 -0400

    revamp walk/1: rebase, add test cases

    Note that according to the new def:

    `{x:0} | walk(.,1)` is equivalent to: {x:0} | walk(.), walk(1)

commit bdec9c0
Author: pkoppstein <pkoppstein@gmail.com>
Date:   Wed Jul 5 02:00:59 2023 -0400

    revamp walk/1

    Resolves jqlang#2584; see also jqlang#2611

commit c8e28da
Author: itchyny <itchyny@cybozu.co.jp>
Date:   Mon Jul 31 09:52:52 2023 +0900

    Redesign website (jqlang#2628)

    * Bump up Bootstrap to v5.3.1, Bootstrap Icon to v1.10.5.
    * Use autoComplete.js to drop dependency on jQuery and typeahead.js.
    * Support dark mode.
    * New svg logo and icon with responsive color mode support.
    * Normalize section ids to lower kebab-case for easiness of linking.
    * Use relative paths for links for local development (--root /output).
    * Various markup cleanups and accessibility improvements.

commit 4af3f99
Author: Owen Ou <o@owenou.com>
Date:   Sat Jul 29 07:20:48 2023 -0700

    Update `bug_report.md` with Discord link

commit 82f7f77
Author: Owen Ou <o@owenou.com>
Date:   Sat Jul 29 07:15:57 2023 -0700

    Redirect questions to Discord

    We now have an official Discord server and most maintainers are hanging
    out there. It would be a good idea to redirect questions to Discord.

commit f733a15
Author: Nicolas Williams <nico@cryptonector.com>
Date:   Mon Jul 10 18:29:03 2023 -0500

    Use -Wno-cast-function-type to quiet many warnings

commit c8b30df
Author: Nicolas Williams <nico@cryptonector.com>
Date:   Mon Jul 10 18:28:33 2023 -0500

    Add JQ_FALLTHROUGH and use it to quiet warnings

commit a6eb055
Author: Emanuele Torre <torreemanuele6@gmail.com>
Date:   Sat Jul 29 21:57:40 2023 +0200

    Fix typo in manual: "-seq" => "--seq"

commit ee2a215
Author: Owen Ou <169064+owenthereal@users.noreply.github.com>
Date:   Sat Jul 29 07:38:08 2023 -0700

    Backfill with references in NEWS.md (jqlang#2788)

    Backfill with references to PRs & issues in NEWS.md

commit eeb08b5
Author: pkoppstein <pkoppstein@gmail.com>
Date:   Wed Jul 5 02:00:59 2023 -0400

    revamp walk/1

    Resolves jqlang#2584; see also jqlang#2611
ncfavier
ncfavier reviewed Aug 7, 2023
View reviewed changes
docs/public/css/style.css
Comment on lines +55 to +58
button{
&[aria-expanded=false] .bi-chevron-down {
display: none;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is cutting edge technology! My Firefox doesn't even support this by default yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I feel sorry for Firefox users but I know that. The feature will be turned on soon; at the end of this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncfavier ncfavier ncfavier left review comments

@wader wader wader approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
1.7 release
4 participants
@itchyny @nicowilliams @wader @ncfavier