Build Docker image using pre-built executables #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
commented
Jul 10, 2023
| CC: "riscv64-linux-gnu" | ||
| CC: riscv64-linux-gnu | ||
| - arch: s390x | ||
| CC: s390x-linux-gnu |
There was a problem hiding this comment.
Sorts alphabetically.
itchyny
commented
Jul 10, 2023
| - powerpc | ||
| - ppc64el | ||
| - riscv64 | ||
| - s390x |
There was a problem hiding this comment.
Preference of YAML array.
itchyny
commented
Jul 10, 2023
| @@ -97,7 +95,7 @@ jobs: | |||
| --with-oniguruma=builtin \ | |||
| --enable-static \ | |||
| --enable-all-static | |||
| make -j$(nproc) | |||
| make -j"$(nproc)" | |||
There was a problem hiding this comment.
For actionlint (shellcheck).
itchyny
commented
Jul 10, 2023
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: jq-${{ env.SUFFIX }} | ||
| name: jq-linux |
There was a problem hiding this comment.
No need to create artifacts separately.
Hmm...I think we may need an explicit |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @userdocs in #2665, I fixed the Docker build job to use the pre-built executables. Also I cleaned up the workflow syntax. The entire workflow was tested here and published here. The docker job runs within 30 seconds (compared to 40 minutes with entire emulation in #2652). BTW, I noticed
ld: warning: option -s is obsolete and being ignoredin macOS build steps. Do we explicitly use the strip or just drop the option? Related PRs: #2665, #2652.