Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indices/1 and rindex/1 in case of overlapping matches in strings #2718

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Fix indices/1 and rindex/1 in case of overlapping matches in strings #2718

merged 1 commit into from
Jul 15, 2023

Conversation

emanuele6
Copy link
Member

Fixes #2433

itchyny
itchyny approved these changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@itchyny itchyny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@itchyny itchyny added this to the 1.7 release milestone Jul 15, 2023
@nicowilliams nicowilliams merged commit 1915b68 into jqlang:master Jul 15, 2023
24 checks passed
@nicowilliams
Copy link
Contributor

Thanks!

@emanuele6 emanuele6 deleted the fixoverlappingindices branch July 25, 2023 21:47
@itchyny itchyny mentioned this pull request Feb 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itchyny itchyny itchyny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7 release
Development

Successfully merging this pull request may close these issues.

rindex yields wrong results on overlapped occurrence
3 participants
@emanuele6 @nicowilliams @itchyny