Respect NO_COLOR environment variable to disable color output #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thanks for working on this! |
|
Should remember to submit jq to https://github.com/jcs/no_color |
Merged
|
Opened PR to add jq to the list: jcs/no_color#255 |
|
@ravron Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
NO_COLORsupport. TheNO_COLORenvironment variable is recognized by various command line tools to disable their color output in terminal. See https://no-color.org for the list of commands and example implementation in C. When--color-output(-C) is used, the color output is enabled regardless of the environment variable (as described in https://no-color.org). This PR resolves #2297.