Remove undocumented and untested --stream-errors option

[itchyny]

This PR drops --stream-errors option. This option is undocumented, and untested. Also buggy; printf '[' | jq --stream-errors . aborts with assertion error.

[nicowilliams]

EDIT: printf '[' | ./jq -c --stream --stream-errors . does not abort (it outputs ["Unfinished JSON term at EOF at line 1, column 1",[0]]). So another fix would be to make --stream-errors imply --stream.

It should be an easy fix:

(gdb) p jv_show(result,0)
["Unfinished JSON term at EOF at line 2, column 0",<invalid>]$1 = void
(gdb)

The problem is that we need to check for .[1] of result being invalid, and then do something about that: dump just .[0] of result, or drop the .[1] of `result.

Now, the question is: is --stream-errors useful? I think it should be!

And this doesn't abort:

: ; printf '[' | ./jq --stream-errors '.[0]'
"Unfinished JSON term at EOF at line 1, column 1"

[nicowilliams]

And:

: ; (./jq -cn '[{a:{b:["c"]}}]'; printf '['; ./jq -cn '["a",{b:"c"}]') | ./jq -c --stream --stream-error
s .
[[0,"a","b",0],"c"]
[[0,"a","b",0]]
[[0,"a","b"]]
[[0,"a"]]
[[0]]
[[0,0],"a"]
[[0,1,"b"],"c"]
[[0,1,"b"]]
[[0,1]]
["Unfinished JSON term at EOF at line 3, column 0",[0]]

[nicowilliams]

One thing we should do is write a fuzzer for the streaming parser. Also, we should document what is and what is not fuzzed so that users who need better security know what features to use / not use.

[itchyny]

Okay, we need to fix the crash, and update the help (after #2747) and the manual.

[nicowilliams]

Okay, we need to fix the crash, and update the help (after #2747) and the manual.

I'll try to get to it tomorrow. Maybe or maybe later tonight.