builtin.jq: simpler and faster transpose #2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that using max/0 is faster than using a stream-oriented version of max
|
Previously |
For backward-compatibility. Add check in jq.test
itchyny
reviewed
Jul 24, 2023
src/builtin.jq
Outdated
| | reduce range(0; $max) as $j | ||
| ([]; . + [reduce range(0;$length) as $i ([]; . + [ $in[$i][$j] ] )] ) | ||
| end; | ||
| # Using map(length) turns out to be faster than using max(stream) |
There was a problem hiding this comment.
I'm still unsure about the stream version of max to be included or not. Users not following the history will be get confused by this comment; where is max(stream)?
There was a problem hiding this comment.
@itchyny - Here, max(stream) is simply short for any valid streaming version of max. That should be clear since no specific referent is mentioned. Feel free to change the wording, though.
There was a problem hiding this comment.
Let's just drop the sentence, we don't need such performance notes here.
There was a problem hiding this comment.
OK. Done in a20c6d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that using max/0 is faster than using a stream-oriented version of max