Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jvp_object_contains: remove unnecessary jv_copy #2937

Merged
merged 2 commits into from
Oct 31, 2023
Merged

jvp_object_contains: remove unnecessary jv_copy #2937

merged 2 commits into from
Oct 31, 2023

Conversation

emanuele6
Copy link
Member

No description provided.

@emanuele6 emanuele6 added the lint Code cleanup; style fixes; small refactors; dead code removal; etc. label Oct 28, 2023
@emanuele6
Copy link
Member Author

I just found a few other unnecessary jv_copy in src/builtin.c

@emanuele6
src/builtin.c: remove unnecessary jv_copy-s in type_error/type_error2
f8d475c 
Also fix doubled semicolon   jv ret;;   =>   jv ret;
wader
wader reviewed Oct 29, 2023
View reviewed changes
src/builtin.c Show resolved Hide resolved
@nicowilliams nicowilliams merged commit f4929f3 into jqlang:master Oct 31, 2023
28 checks passed
@nicowilliams
Copy link
Contributor

Thanks!

@emanuele6 emanuele6 deleted the nocopy branch October 31, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicowilliams nicowilliams nicowilliams left review comments

@wader wader wader approved these changes

Assignees
No one assigned
Labels
lint Code cleanup; style fixes; small refactors; dead code removal; etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emanuele6 @nicowilliams @wader