ascii_upcase and ascii_downcase #595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: docs/content/3.manual/manual.yml
…d test case. Always yields an integer (even if input is unsorted); returns (-1 - ix) if x is not in input array.
|
Oh geez, I owe you a review. |
|
Cherry-picked. Thanks! EDIT: I meant to make this comment on specific comments. |
|
The only commit I didn't take was the one for gsub. It needs a bit of work. |
|
Thanks for cherry-picking ascii_upcase, ascii_downcase, and especially bsearch! (@wtlangford had already processed transpose and gsub/3 in 85f0e30.) |
|
Oh, whoops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming in accordance with suggestion at #592