Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional options to codecov-action #272

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Add additional options to codecov-action #272

merged 2 commits into from
Jun 20, 2024

Conversation

avylove
Copy link
Collaborator

@avylove avylove commented Jun 20, 2024

I noticed after the last PR that a CodeCov report hadn't been generated. It looks like they haven't worked for a few months. It seems they are now requiring a token where previously it was optional. I also added the option to fail if codecov fails, which used to happen when we used the cli directly, but is disabled by default with the codecov action.

I also tried to update the action to V4, but that failed for 2.7 because the action (both V3 and V4) use a PyInstaller wrapped binary of the codecov-cli and one of the subcommands used in V4 is looking for a slightly newer version of glibc than the docker image for 2.7 provides. codecov/codecov-action#1277

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.31%. Comparing base (75a34ef) to head (950a4b1).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage   95.41%   95.31%   -0.10%     
==========================================
  Files           9        9              
  Lines        1025     1025              
  Branches      216      216              
==========================================
- Hits          978      977       -1     
- Misses         43       44       +1     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@jquast jquast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for noticing and repairing it!

@avylove avylove merged commit 167c34e into master Jun 20, 2024
28 of 29 checks passed
@avylove avylove deleted the codecov_fixes branch June 20, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants