Add additional options to codecov-action #272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed after the last PR that a CodeCov report hadn't been generated. It looks like they haven't worked for a few months. It seems they are now requiring a token where previously it was optional. I also added the option to fail if codecov fails, which used to happen when we used the cli directly, but is disabled by default with the codecov action.
I also tried to update the action to V4, but that failed for 2.7 because the action (both V3 and V4) use a PyInstaller wrapped binary of the codecov-cli and one of the subcommands used in V4 is looking for a slightly newer version of glibc than the docker image for 2.7 provides. codecov/codecov-action#1277