fix: zero duration no-overlap events (#2213)

Corrects issue with the no-overlap algorithm with events that have no duration
jquense · Jul 7, 2022 · bbe1109 · bbe1109
1 parent c2bd6b8
commit bbe1109
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 3 deletions.
diff --git a/src/utils/layout-algorithms/no-overlap.js b/src/utils/layout-algorithms/no-overlap.js
@@ -51,7 +51,7 @@ export default function ({
       const y4 = se2.style.top + se2.style.height
 
       // be friends when overlapped
-      if ((y3 <= y1 && y1 < y4) || (y1 <= y3 && y3 < y2)) {
+      if ((y3 <= y1 && y1 <= y4) || (y1 <= y3 && y3 <= y2)) {
         // TODO : hashmap would be effective for performance
         se1.friends.push(se2)
         se2.friends.push(se1)

diff --git a/stories/Layout.stories.js b/stories/Layout.stories.js
@@ -13,10 +13,12 @@ export default {
 
 const Template = (args) => <Calendar {...args} />
 
+const defaultDate = new Date()
+
 export const EventLayout = Template.bind({})
 EventLayout.args = {
   defaultView: Views.DAY,
-  defaultDate: new Date(),
+  defaultDate,
   timeslots: 4,
   events: createEvents(1),
 }
@@ -174,3 +176,26 @@ export const ZeroDurationOddities = () => {
     />
   )
 }
+
+export const ZeroDurationOverlap = () => {
+  return (
+    <DragAndDropCalendar
+      defaultDate={defaultDate}
+      events={[
+        {
+          title: 'event a',
+          start: defaultDate,
+          end: defaultDate,
+        },
+        {
+          title: 'event b',
+          start: defaultDate,
+          end: defaultDate,
+        },
+      ]}
+      dayLayoutAlgorithm={'no-overlap'}
+      scrollToTime={defaultDate}
+      defaultView={Views.WEEK}
+    />
+  )
+}
diff --git a/stories/helpers/index.js b/stories/helpers/index.js
@@ -22,7 +22,9 @@ const localizer = momentLocalizer(moment)
 export const date = (...args) => moment(...args).toDate()
 
 export const Calendar = (props) => (
-  <BaseCalendar localizer={localizer} {...props} />
+  <div style={{ height: 650 }}>
+    <BaseCalendar localizer={localizer} {...props} />
+  </div>
 )
 
 export const DragAndDropCalendar = withDragAndDrop(Calendar)