Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update overlay #1301

Merged
merged 26 commits into from
May 8, 2019
Merged

Conversation

cutterbl
Copy link
Collaborator

@cutterbl cutterbl commented May 6, 2019

Update the react-overlay dependency and usage within the project. Necessary update to avoid conflicts with those using latest version of react-overlay (for instance, those creating Modal managers in their projects, consuming react-bootstrap).

Copy link
Collaborator

@arecvlohe arecvlohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable change, thanks!

@arecvlohe
Copy link
Collaborator

@jquense Thoughts?

@cutterbl
Copy link
Collaborator Author

cutterbl commented May 6, 2019

I fixed the merge conflict. Since the Popup get's it's ref from Overlay, there's no need for the createRef directly in the Popup.

@cutterbl
Copy link
Collaborator Author

cutterbl commented May 6, 2019

Sorry for the back and forth. The only OS projects I regularly send updates to are my own, so reacquainting with the workflow here. Think all the bits are there now. Tests are passing, examples are rebuilt and running properly, and no console messages.

src/Month.js Outdated Show resolved Hide resolved
cutterbl and others added 15 commits May 7, 2019 09:49
fix: TimeGrid display on DST change days when min is after the transi…
merging latest from base project
…eact-big-calendar into feature/updateOverlay

* 'feature/updateOverlay' of https://github.com/cutterbl/react-big-calendar:
  Merge latest updates from master and rebuild examples
  Import change, according to maintainer feedback
  Add proper PropType for popperRef
  forgot the examples
  Add notes and rebuild examples
  Proper ref forwarding
  Fix ref reference for proper offset calcs
  unnecessary key
  Update react-overlays dependency and usage

# Conflicts:
#	examples/bundle.js
#	examples/bundle.js.map
#	yarn.lock
@cutterbl
Copy link
Collaborator Author

cutterbl commented May 8, 2019

Do you need anything else for this update?

@jquense jquense changed the title Feature/update overlay chore(deps): update overlay May 8, 2019
@jquense jquense merged commit 5d9a16f into jquense:master May 8, 2019
@jquense
Copy link
Owner

jquense commented May 8, 2019

thanks!

cutterbl added a commit to cutterbl/react-big-calendar that referenced this pull request May 8, 2019
@cutterbl cutterbl deleted the feature/updateOverlay branch May 8, 2019 21:23
@github-actions
Copy link

🎉 This PR is included in version 0.38.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants