Correct calculation of .rbc-event-continues-after class #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nosnaj
approved these changes
Sep 11, 2017
anissaSanadtech
approved these changes
Sep 18, 2017
|
Surely this PR is straightforward and safe to merge? I have already personally tested this out and it fixes my issue. However, the same cannot be said for the events that get rendered in the popup. Correctly rendering in day view:
Wrong in the popup:
The red and blue right/left borders are just custom visual cues for the start/end of an event. Ignore the content as they are just test fillers. |
jquense
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #448