ajaxSubmit not compatible with jQuery>=1.12.1

[senendds]

I don't know if this plugin is still supported (it seems it's not), but in case anyone is interested, there is a problem with this code in ajaxSubmit:

    if (!options.dataType && options.target) {
        var oldSuccess = options.success || function(){};
        callbacks.push(function(data) {
            var fn = options.replaceTarget ? 'replaceWith' : 'html';
            $(options.target)[fn](data).each(oldSuccess, arguments);
        });
    }

because, in jQuery 1.12.1, they have changed the function each() from

    // Execute a callback for every element in the matched set.
    // (You can seed the arguments with an array of args, but this is
    // only used internally.)
    each: function( callback, args ) {
        return jQuery.each( this, callback, args );
    },

to

    // Execute a callback for every element in the matched set.
    each: function( callback ) {
        return jQuery.each( this, callback );
    },

That means that the success callback function is called without parameters.

[rajeshdk]

Hi This code is not working with new Jquery 2.2

$(document).on('change', '#image_upload_file', function () {
var progressBar = $('.progressBar'), bar = $('.progressBar .bar'), percent = $('.progressBar    .percent');

$('#image_upload_form').ajaxForm({
beforeSend: function() {
    progressBar.fadeIn();
    var percentVal = '0%';
    bar.width(percentVal);
    percent.html(percentVal);
},
uploadProgress: function(event, position, total, percentComplete) {
    var percentVal = percentComplete + '%';
    bar.width(percentVal);
    percent.html(percentVal);
},
success: function(html, statusText, xhr, $form) {       
    var obj = $.parseJSON(html);    
    if(obj.status){     
        var percentVal = '100%';
        bar.width(percentVal);
        percent.html(percentVal);
         $("#imgArea img").load(function() {
         $(this).hide();
         $(this).fadeIn('slow');
          }).attr('src', 'images/logo.jpg?'+ new Date().getTime());

    }else{
        alert(obj.error);
    }
},
complete: function(xhr) {
    progressBar.fadeOut();          
}   
}).submit();        

});`

Is there anyway to fix it, thanks

[kavin-90]

Working Fine on 2.2.3 no problem at all

Code

// Post Tweet
var msg = $('#message');
$("#twitter").attr("disabled", true);
$('#twitter-post').keyup(function(e){
val = $(this).val().trim();
if(val.length == 0){
$("#twitter").attr("disabled", true);
}
else{
$("#twitter").attr("disabled", false);

$("#compose").ajaxForm({
beforeSend: function(data) {
e.preventDefault();
msg.empty();
},
complete: function(xhr) {

var obj = JSON.parse(xhr.responseText); 

var msg_content = obj.msg;

var html_body_success = "<div class='alert alert-success'><button type='button' class='close' data-dismiss='alert' aria-label='Close'><span aria-hidden='true'>&times;</span></button><span class='glyphicon glyphicon-remove'></span>"+ msg_content +"</div>";

var html_body_error = "<div class='alert alert-danger'><button type='button' class='close' data-dismiss='alert' aria-label='Close'><span aria-hidden='true'>&times;</span></button><span class='glyphicon glyphicon-remove'></span>"+ msg_content +"</div>";

if(obj.success){
msg.html(html_body_success);

$('#twitter-post').clearInputs();
$("#twitter").attr("disabled", true);
} else {
msg.html(html_body_error);
}

$('div.dz-success').remove();

}
});
}
});

[senendds]

As I said, it is the success callback what is not working. You have to change this line

$(options.target)[fn](data).each(oldSuccess, arguments);

with something like

$(options.target)[fn](data).each(function(){
   oldSuccess.call(this, data, status, xhr);
});

[kavin-90]

Works no Problem with Success too
jQuery Form Plugin
version: 3.51.0-2014.06.20

jQuery v2.2.3

// Post Tweet
var msg = $('#message');
$("#twitter").attr("disabled", true);
$('#twitter-post').keyup(function(e){
val = $(this).val().trim();
if(val.length == 0){
$("#twitter").attr("disabled", true);
}
else{
$("#twitter").attr("disabled", false);

$("#compose").ajaxForm({
beforeSend: function(data) {
e.preventDefault();
msg.empty();
},
success: function(xhr) {

var obj =  xhr;

var msg_content = obj.msg;

var html_body_success = "<div class='alert alert-success'><button type='button' class='close' data-dismiss='alert' aria-label='Close'><span aria-hidden='true'>&times;</span></button><span class='glyphicon glyphicon-remove'></span>"+ msg_content +"</div>";

var html_body_error = "<div class='alert alert-danger'><button type='button' class='close' data-dismiss='alert' aria-label='Close'><span aria-hidden='true'>&times;</span></button><span class='glyphicon glyphicon-remove'></span>"+ msg_content +"</div>";

if(obj.success){
msg.html(html_body_success);

$('#twitter-post').clearInputs();
$("#twitter").attr("disabled", true);
} else {
msg.html(html_body_error);
}

$('div.dz-success').remove();

}
});
}
});

[senendds]

The problem only happens if (!options.dataType && options.target).

You are not specifying a target, that's why you don't meet the problem.

[xael-fry]

I confirm the issue, I have exactly the same issue after upgrading jquery

[titus65]

Same problem here with ajaxForm (success is called with undefined form object) when upgrading from jq 1.7.2 to 1.12.3

[kevindb]

Are you still experiencing this issue with version 4.0.1+?

[titus65]

On Tue, Feb 21, 2017 at 01:48:45PM -0800, Kevin Morris wrote: Are you still experiencing this issue with version 4.0.1+?

Yes, same problem.

…

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #495 (comment)

[kevindb]

Would you please create an example of the error on CodePen or JSFiddle?

[vkurup]

Here's a quick example: https://jsfiddle.net/etdssL0h/10/

[kevindb]

Thank you, @vkurup, that's very helpful to understanding the issue.
Would someone please submit a pull request with the necessary fix? @senendds perhaps?