Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outside fields bug fix #461

Closed
wants to merge 2 commits into from
Closed

Outside fields bug fix #461

wants to merge 2 commits into from

Conversation

Finesse
Copy link

@Finesse Finesse commented Mar 25, 2015

In non-IE browsers outside fields are already included in elements attribute of form, so there is no need to add outside fields again.

In non-IE browsers outside fields are already included in `elements` attribute of form, so there is no need to add outside fields again.
@kevindb
Copy link
Contributor

kevindb commented Mar 6, 2017

@FinesseRus, would you please create a CodePen or JSFiddle example of the issue where fields are being added a second time?

@Finesse
Copy link
Author

Finesse commented Mar 7, 2017

@kevindb Here it is: http://codepen.io/TheFinesse/pen/NpREpp?editors=1010

There are 3 inputs in the console instead of 2 in any browser except IE and Edge.

@kevindb kevindb closed this in 76c7c90 Mar 7, 2017
@kevindb
Copy link
Contributor

kevindb commented Mar 7, 2017

Thank you for your PR and CodePen example. I was able to use the CodePen to create an actual automated test for this! Squee!

@Finesse
Copy link
Author

Finesse commented Mar 7, 2017

@kevindb I'm glad that the pull request hasn't been ignored

@kevindb
Copy link
Contributor

kevindb commented Mar 7, 2017

I'm trying to breathe new life into this plugin. I've used it in enough projects myself, and I have yet to find something that works better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants