restore value capturing for forms without submit button #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our code base we have a few tiny forms like this, that are just a
checkbox that trigger an ajax post:
<form action="/" method="post" id="domain_haupt_form_asd_de">
<input type="hidden" name="domain" value="asd.de">
<input type="checkbox" onchange="$(this).submit()">
</form>
Before the fix for jquery-form#365 was included this worked perfectly fine, but after
its inclusion the value for domain stopped being sent along, since e.target
points at the checkbox input and ajaxSubmit sends that input to
formToArray, which has no clue as to what to do with it and fails to
extract the form values.
|
This pull request was merged into the maintained fork of this plugin at #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our code base we have a few tiny forms like this, that are just a checkbox that trigger an ajax post:
Before the fix for #365 was included this worked perfectly fine, but after its inclusion the value for domain stopped being sent along, since e.target points at the checkbox input and ajaxSubmit sends that input to formToArray, which has no clue as to what to do with it and fails to extract the form values.