Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: replace grunt-contrib-qunit with jQuery test runner #135

Merged
merged 6 commits into from
Apr 7, 2024
Merged

Test: replace grunt-contrib-qunit with jQuery test runner #135

merged 6 commits into from
Apr 7, 2024

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Apr 5, 2024 •
edited
Loading

  • Removed karma and testswarm
  • added GH actions workflow to run tests against all supported jQuery versions in 4 major browsers
  • Intentionally left out a workflow for updating git files on filestash. We will no longer update those.

@timmywil timmywil added this to the 3.0.0 milestone Apr 5, 2024
@timmywil timmywil requested a review from mgol April 5, 2024 02:44
mgol
mgol reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good but I have a few comments

package.json Show resolved Hide resolved
Gruntfile.js Show resolved Hide resolved
test/runner/browserstack/api.js Show resolved Hide resolved
mgol
mgol approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@timmywil
Copy link
Member Author

timmywil commented Apr 7, 2024

Disabled jenkins workflows for color

@timmywil timmywil merged commit d14ba1d into jquery:main Apr 7, 2024
5 checks passed
@timmywil timmywil deleted the tests branch April 7, 2024 15:11
@timmywil timmywil mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgol mgol mgol approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@timmywil @mgol