Skip to content

Commit

Permalink
Tests: Workaround a jQuery 1.8 issue with one dialog test
Browse files Browse the repository at this point in the history
The test "#8958: dialog can be opened while opening" had special behavior in
jQuery 1.8 and the patch from commit 7adb13a
broke those assumptions. Adjust the test so that it passes again.

Closes gh-2229
  • Loading branch information
mgol authored Apr 12, 2024
1 parent b4df487 commit ab2a2a9
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions tests/unit/dialog/methods.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,8 @@ QUnit.test( "#8958: dialog can be opened while opening", function( assert ) {
var ready = assert.async( 3 );
assert.expect( 1 );

var jQuery1Dot8 = jQuery.fn.jquery.indexOf( "1.8" ) === 0;

var element = $( "<div>" ).dialog( {
autoOpen: false,
modal: true,
Expand Down Expand Up @@ -246,6 +248,15 @@ QUnit.test( "#8958: dialog can be opened while opening", function( assert ) {
// handle a call to the open() method during the process of the dialog
// being opened.
.on( "blur", function() {

// Support: jQuery 1.8 only
// The test never fully worked in jQuery 1.8 since the input's blur
// handler never fired. It's only been uncovered when `ready()` calls
// have been added to all handlers. Skip this handler in jQuery 1.8.
if ( jQuery1Dot8 ) {
return;
}

element.dialog( "open" );

// Detach the handlers to avoid firing them outside of this
Expand All @@ -255,6 +266,13 @@ QUnit.test( "#8958: dialog can be opened while opening", function( assert ) {
ready();
} )
.trigger( "focus" );

// Support: jQuery 1.8 only
// Account for the skipped `ready()` call above. To make sure the count
// is constant, call it here instead.
if ( jQuery1Dot8 ) {
ready();
}
} );

QUnit.test( "#5531: dialog width should be at least minWidth on creation", function( assert ) {
Expand Down

0 comments on commit ab2a2a9

Please sign in to comment.