Tests: Increase robustness of a draggable revert test
#2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the changes is increasing `revertDuration` from 200 to 300. For some reason, when jQuery 3.1 is used in an iframe (which TestSwarm uses) the timings are lower than expected and `setTimeout` too slow and the check for animation happens too late.
fnagel
approved these changes
Apr 11, 2024
| @@ -1045,6 +1045,7 @@ QUnit.test( "revert and revertDuration", function( assert ) { | |||
| testHelper.move( element, 50, 50 ); | |||
| setTimeout( function() { | |||
| assert.ok( $( "#draggable2" ).is( ":animated" ), "revert: true with revertDuration should animate" ); | |||
| ready(); | |||
There was a problem hiding this comment.
Yes, I wanted the test to wait for this as well - that's why the call assert.async() now takes 2 as an argument - it means ready() needs to be called twice before the test is marked as finished.
timmywil
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the changes is increasing
revertDurationfrom 200 to 300. For some reason, when jQuery 3.1 is used in an iframe (which TestSwarm uses) the timings are lower than expected andsetTimeouttoo slow and the check for animation happens too late.