Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown-inline-code-face's :inherit attribute #252

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

peniblec
Copy link
Contributor

@peniblec peniblec commented Sep 4, 2017

Hi! When inline code lost its foreground color some months ago,
I assumed it was a stylistic choice and did not question it; when
I tried to Customize the face recently, however, the Custom menu
spewed a broken face form.

AFAIK :inherit takes either a single face, or a sequence of faces, so
I guess the declaration ought to be fixed?

@jrblevin
Copy link
Owner

Apologies for the delay in incorporating this, but I wanted to go back and check the commit to see what I was thinking. Indeed, it was a typo. The idea was that all code faces (incl. inline code) would inherit from markdown-code-face. Thanks for catching this!

@jrblevin jrblevin merged commit 6419d71 into jrblevin:master Sep 25, 2017
jrblevin added a commit that referenced this pull request Sep 25, 2017
Add entry for GH-252.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants