Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimagit opens in location list #119

Closed
fpnick opened this issue Feb 24, 2017 · 3 comments
Closed

vimagit opens in location list #119

fpnick opened this issue Feb 24, 2017 · 3 comments
Labels
bug feedback fixed in master fixed in next
Milestone
Release 1.7.1

Comments

@fpnick
Copy link

fpnick commented Feb 24, 2017

Hi Jerome,

since upgrading to 1.7, vimagit sometimes (I know this is very vague, but I cannot specify it just yet) opens in the location list panel, rather than in a vsplit.

Is that intended somehow, or is it a bug?

Thanks,
Fabian.
jreybert added a commit that referenced this issue Feb 24, 2017
@jreybert
Revert "plugin/magit.vim: simplify auto jump to magit window if any"
ed36a0f 
This reverts commit f5756b2.

ref #119
it is not really related to location window, actually, it does not work
as excpected: window numbers are not consistent:
- winnr() == 1
- vsplit, jump to new window
- winnr() == 1
- last window, winnr() == 2
- close winnr()==1, remaing window winnr()==1
@jreybert
Copy link
Owner

It is actually a bug, I reverted the faulty commit.

Thanks for the report!

@jreybert
Copy link
Owner

Could you confirm that it fixes your issue please?

@jreybert jreybert modified the milestone: Release 1.7.1 Feb 27, 2017
@fpnick fpnick mentioned this issue Feb 28, 2017
Closed
@fpnick
Copy link
Author

fpnick commented Feb 28, 2017 •
edited
Loading

Sorry for the delay, I wanted to reproduce that at work which is where I noticed the issue.
It's fixed now, however now I get #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feedback fixed in master fixed in next
Projects
None yet
Milestone
Release 1.7.1
Development

No branches or pull requests
2 participants
@jreybert @fpnick