Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'q' in MagitOnly buffer should show the previous buffer #137

Closed
jreybert opened this issue May 23, 2017 · 5 comments
Closed

'q' in MagitOnly buffer should show the previous buffer #137

jreybert opened this issue May 23, 2017 · 5 comments

Comments

@jreybert
Copy link
Owner

BTW, this also relates to a request regarding the q shortcut in a magit buffer: If this buffer was opened with :MagitOnly, it currently closes the window. Instead, it should behave like said before and show the previous buffer instead of closing the window.

Seen in #132 and #130

jreybert added a commit that referenced this issue May 23, 2017
I hope all the cases are well handled and it does break anything

fix #137
@jreybert
Copy link
Owner Author

jreybert commented May 23, 2017

@guyzmo @sebastianst could you please try the dev/close branch please? thanks for your feedback.

@sebastianst
Copy link

q now leaves the window open when magit was opened with :MagitOnly. Thank you!
However, after committing the last change and the repo state is clean, the window still remains open and doesn't close automatically (#132).

@jreybert
Copy link
Owner Author

@sebastianst glad it fits your need. And I did not forgot #132, I just split this issue up.

@guyzmo
Copy link

guyzmo commented Aug 1, 2017

@jreybert
Copy link
Owner Author

jreybert commented Aug 8, 2017

Merged in master and present in release 1.7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants