Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ex command to unhide all hunks at magit opening #18

Closed
hoschi opened this issue Oct 15, 2015 · 9 comments
Closed

Add Ex command to unhide all hunks at magit opening #18

hoschi opened this issue Oct 15, 2015 · 9 comments

Comments

@hoschi
Copy link

hoschi commented Oct 15, 2015

This would be really usefull to get a quick overview. It should be an opt-in feature, because this can be slow with huge changes, I think.

@jreybert
Copy link
Owner

Hi hoschi,

could you explain what you mean by diff mode?

If you mean side by side diff, please could you provide some example (a schema for example) describing how you imagine such mode with magit workflow.

Thanks

@hoschi
Copy link
Author

hoschi commented Oct 15, 2015

I mean all file hunks are shown and expanded. This way you don't have to go
to each file and press enter followed by zO to expand all hunks of that
file.

Jérôme Reybert notifications@github.com schrieb am Do., 15. Okt. 2015
20:42:

Hi hoschi,

could you explain what you mean by diff mode?

If you mean side by side diff, please could you provide some example (a
schema for example) describing how you imagine such mode with magit
workflow.

Thanks


Reply to this email directly or view it on GitHub
#18 (comment).

@hoschi
Copy link
Author

hoschi commented Oct 15, 2015

Sorry, 'overview' isn't a good word for that kind of view. I meant it
should be an overview of all changes as diff.

Stefan Gojan vollekannehoschi@gmail.com schrieb am Do., 15. Okt. 2015
23:04:

I mean all file hunks are shown and expanded. This way you don't have to
go to each file and press enter followed by zO to expand all hunks of
that file.

Jérôme Reybert notifications@github.com schrieb am Do., 15. Okt. 2015
20:42:

Hi hoschi,

could you explain what you mean by diff mode?

If you mean side by side diff, please could you provide some example (a
schema for example) describing how you imagine such mode with magit
workflow.

Thanks


Reply to this email directly or view it on GitHub
#18 (comment).

@jreybert
Copy link
Owner

OK! That's an easy one :) I reword the issue title.

It'll be in next release then.

Thanks for the feedback.

@jreybert jreybert added this to the Release 1.4 milestone Oct 16, 2015
@jreybert jreybert changed the title Add Ex command to open magit buffer in diff mode Add Ex command to unhide all hunks at magit opening Oct 16, 2015
@hoschi
Copy link
Author

hoschi commented Oct 16, 2015

👏
cool you like the idea :)

@hoschi
Copy link
Author

hoschi commented Oct 31, 2015

I updated the plugin and configured it to show all files/hunk expanded, works like a charm 👍

@jreybert
Copy link
Owner

glad to hear it works. I am curious, did you use global parameters or show_magi() parameter with a new mapping?

@hoschi
Copy link
Author

hoschi commented Nov 1, 2015

I used the global parameters to make a "show all hunks" (default) version. When I run into performance or "too much diff" problems, I think about how to use show_magit() function to fix this.

@jreybert
Copy link
Owner

jreybert commented Nov 1, 2015

I have several ideas for performance issues.

For example, add a configuration parameter to never show untracked files (see #28).

Another optimization should also appear soon in next, optimizing performance for closed files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants