Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in default folding behavior #62

Closed
jebaum opened this issue Feb 1, 2016 · 4 comments · Fixed by #63
Closed

Bug in default folding behavior #62

jebaum opened this issue Feb 1, 2016 · 4 comments · Fixed by #63
Labels
Milestone

Comments

@jebaum
Copy link
Contributor

jebaum commented Feb 1, 2016

Without setting g:magit_default_fold_level, or setting it to 1, when I first load :Magit, the hunks are unfolded. I figured out this is because my vimrc has set foldnestmax=1 in it, which I like for normal editing, but having a higher foldnestmax (like the vim default of 20) is needed for magit. I think the Magit buffer ought to do setlocal foldnestmax=20 to solve this.

@jreybert
Copy link
Owner

jreybert commented Feb 1, 2016

Hi,

it seems to be the proper way to do that. Would you mind to add it in vimagit and propose a pull request? It should be in magit#show_magit function, near other setlocalassignments.

@jreybert jreybert added the bug label Feb 1, 2016
@jebaum
Copy link
Contributor Author

jebaum commented Feb 1, 2016

I'll do that, thanks for pointing me to the right place

@jreybert
Copy link
Owner

jreybert commented Feb 1, 2016

Nice! May I ask you to push again, adding "(fix #62)" at the end of the title commit message

jebaum added a commit to jebaum/vimagit that referenced this issue Feb 2, 2016
@jebaum
Copy link
Contributor Author

jebaum commented Feb 2, 2016

done

jreybert added a commit that referenced this issue Feb 2, 2016
plugin/magit.vim: in show_magit(), set foldnestmax  (fix #62)
jreybert added a commit that referenced this issue Feb 2, 2016
* 'master' of github.com:jreybert/vimagit:
  plugin/magit.vim: in show_magit(), set foldnestmax (fix #62)
@jreybert jreybert modified the milestone: Release 1.5.2 Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants