Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <nowait> to magit mappings #85

Closed
ghost opened this issue Apr 29, 2016 · 6 comments
Closed

Add <nowait> to magit mappings #85

ghost opened this issue Apr 29, 2016 · 6 comments

Comments

@ghost
Copy link

ghost commented Apr 29, 2016

Hey, consider adding to g:magit_close_mapping to reduce delay for those who have global q* mappings set.

@jreybert
Copy link
Owner

Ho, I did not know this option...

Well, I will be consider it, but maybe not only for q mapping. I'll check how other plugins play with this in special buffers mapping.

@alok
Copy link

alok commented Nov 1, 2016

I'm also interested in this.

I use the s key to stage, but I have a global mapping that conflicts, and it's annoying to have to wait a second for the mapping to work.

@jreybert
Copy link
Owner

jreybert commented Nov 2, 2016

I understand your concern.

I am quite reluctant to add nowait, I don't understand all the possible consequences for the moment.

I would like to do a full review of technical ways to provide default mapping first, and see the best fit for vimagit, for example using <Plug> prefix. I do believe it should fix your concern.

See http://whileimautomaton.net/2008/09/27022735

@jreybert
Copy link
Owner

jreybert commented Nov 2, 2016

@Shougo 's code to use nowait

function! s:nowait_map(mode) abort "{{{
  return a:mode.'map <buffer>'
        \ . ((v:version > 703 || (v:version == 703 && has('patch1261'))) ?
        \ '<nowait>' : '')
endfunction "}}}

@jreybert jreybert changed the title Add nowait to q mapping. Add nowait magit mappings Nov 22, 2016
@jreybert jreybert changed the title Add nowait magit mappings Add <nowait> to magit mappings Nov 22, 2016
@jreybert
Copy link
Owner

@kwinczek @alok could you please give a try to branch dev/mapping

@ghost
Copy link
Author

ghost commented Feb 21, 2017

@jreybert Seems alright to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants