Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After remapping, CC adds previous commit message #94

Closed
hkupty opened this issue Sep 30, 2016 · 13 comments
Closed

After remapping, CC adds previous commit message #94

hkupty opened this issue Sep 30, 2016 · 13 comments

Comments

@hkupty
Copy link
Contributor

hkupty commented Sep 30, 2016

After setting let g:magit_commit_mapping="cc", if I do multiple commits for the same repo or without closing vim (changing pwd to another project) it places the previous commit message.

It keeps the commit mode as normal, though.

@hkupty hkupty changed the title After remapping, CC behaves as CA After remapping, CC adds previous commit message Sep 30, 2016
@jreybert
Copy link
Owner

I can't reproduce your issue. Could you:

  • try to reproduce disabling all the others plugins
  • make a step by step description

Thanks

@jreybert jreybert added the bug label Oct 19, 2016
@jreybert jreybert added this to the Release 1.7.0 milestone Oct 19, 2016
@jreybert
Copy link
Owner

Hi,

could you please provide a step by step description on how to reproduce your bug? I would like to fix it for next release.

@hkupty
Copy link
Contributor Author

hkupty commented Oct 19, 2016

Sorry for taking long to answer, I've been on a rush for the last few days.

I'm thinking this may be related to tcd somehow. When I opened the issue, it looked like (for some random order of events) that changing the commit mapping would cause the message to appear, even if normal commit.

I'll ask you to keep this on-hold as I'll investigate further (while addressing the comments for the PRs #93 and #95).

@jreybert
Copy link
Owner

OK thanks for your feedback.

@jreybert
Copy link
Owner

jreybert commented Nov 3, 2016

Someone pointed me this out:
when this has happened to you, did you began a commit with another tool such as git gui or git cola?

@hkupty
Copy link
Contributor Author

hkupty commented Nov 3, 2016

No. The thing is, it used to happen prior to fixing tcd. I'm using next now and it never happened again (it was pretty common before).

I think we can close this for now. I'm using vimagit on daily basis and I'm pretty sure fixing tcd fixed it.

Just found out why it happens:
{,t,l}cd is on a path, but the file is from other path This causes the vimagit window to open for the repo of the current file, but with the message from previous commit of the repo of cd/tcd/lcd.

@alok
Copy link

alok commented Nov 20, 2016

FWIW, I've also had this issue. I'm using next.

@jreybert
Copy link
Owner

@alok do you use tcd?

@alok
Copy link

alok commented Nov 21, 2016

@jreybert No.

@jreybert
Copy link
Owner

Do you use tools like git gui or git cola?

@alok
Copy link

alok commented Nov 22, 2016

No. I only use the command line, and recently I've only used vimagit,
except to push.
On Tue, Nov 22, 2016 at 1:57 AM Jérôme Reybert notifications@github.com
wrote:

Do you use tools like git gui or git cola?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#94 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH8KTIs7EI4IAdWYeahvgED7LAmrp7r2ks5rArx0gaJpZM4KLiwj
.

  • Alok

@hkupty
Copy link
Contributor Author

hkupty commented Nov 22, 2016

@alok can you reproduce the bug? I'm pretty sure this is fixed on next..

@alok
Copy link

alok commented Nov 23, 2016

I just updated and I'm not seeing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants