-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command for close section for commit #54
Conversation
Additional comment. |
Hi bakunyo, thanks for your PR! I had it in my mind for a while, and I never took the time to add it. You did a good job, too bad that travis is unstable at this moment. I don't see why your commit would fail with the test suite, I think it should be OK. We will see when travis will be back to normal. Anyway, waiting for travis revival, I would have sevral requests to make this PR complete:
Thanks |
Hello, Need to press two times the u key if you start writing the commit |
7b496a0
to
d1fc4eb
Compare
Hello jreybert, Thanks for comment! |
Hello zimski, Thanks for your comment. Though in rare cases, some changes might be staged or unstaged after commit section opened. |
d1fc4eb
to
d8adf2d
Compare
Sorry for sending too PRs. Could you close either isn't needed. |
@zimski no, just pressing 'u' won't be enough. vimagit is not a nomrla vim buffer. It has some internal variable states. It has one to check that a commit message write is ongoing. Just pressing 'u' won't update this variable. |
Hello, jreybert.
I want to add a command that can close commit section.
Added key 'CU' means 'commit undo'.
Could you see this PR and merge if the commit is acceptable.