Correctly handle Unicode file names in ExcHndl, add tests #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `ExcHndlSetLogFileNameW` that accepts a Unicode wide character string as an alternative to `ExcHndlSetLogFileNameA`, which uses the current Windows code page. Internally only the wide character string is stored. The file name passed to `ExcHndlSetLogFileNameA` is converted to wide characters using the current code page. Use `GetModuleFileNameW` instead of `GetModuleFileNameA` to handle the case that the module file name contains Unicode characters. Don't use `%s` in format strings to print the argument when it's a nullptr, as this is undefined behavior.
As a lot of testing code also had to be adjusted for usage of wide character strings, it was easiest to split the existing test code by adding another compile time flag `TEST_UNICODE`. The flag is not named `UNICODE`, as this name is already used by the Windows API. A macro `WFILE` is added that expands to a wide character string literal containing `__FILE__`. The output file name for the unicode tests contains additional unicode characters to properly test the behavior.
Robyt3
force-pushed
the
ExcHndl-Unicode
branch
from
ccfa038 to
f5a7978
Compare
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 50.66% 48.48% -2.19%
==========================================
Files 15 15
Lines 1954 1941 -13
Branches 742 740 -2
==========================================
- Hits 990 941 -49
- Misses 743 770 +27
- Partials 221 230 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Looks great. Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages below.
Closes #74.