Fix handling of sectioned source maps missing 'names' array #29
Conversation
There was a problem hiding this comment.
AFAIK just like for regular source maps, the
namesarray can be omitted for maps in sectioned/index source maps.
This is incorrect. Each map in a section is an embedded complete source map object, and a source map object has a non-optional names array.
src/any-map.ts
Outdated
| @@ -111,7 +111,9 @@ function addSection( | |||
| const { resolvedSources, sourcesContent: contents } = map; | |||
|
|
|||
| append(sources, resolvedSources); | |||
| append(names, map.names); | |||
| if (map.names) { | |||
| append(names, map.names); | |||
There was a problem hiding this comment.
Instead of doing this here, we can normalize the map to always contain a names array. map is just a TraceMap instance, so we just need to update
trace-mapping/src/trace-mapping.ts
Line 166 in 5ccfcfe
Even though the 'names' array is seen as required, normalize it to an empty array if omitted Currently, trace-mapping will throw with an exception "Cannot read properties of undefined (reading 'length')" in case no 'names' array is provided.
RandomByte
force-pushed
the
sectioned-source-map-omit-names-array
branch
from
f60214e
to
65818ba
Compare
|
Thanks for the fast feedback! From reading the spec, it was not entirely clear to me which fields where required, but I see now that only few are declared as "optional". I updated the PR as proposed and amended the existing commit. We'll also fix our index source maps to always include a names array 👍 |
JIRA: CPOUI5FOUNDATION-802 jridgewell/trace-mapping#29 got resolved and merged, but Terser still have not updated their dependency
Even though the
namesarray is seen as required, normalize it to an empty array if omittedCurrently, trace-mapping will throw with an exception
"Cannot read properties of undefined (reading 'length')"in case no 'names' array is provided.