Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max error reported leaf pair incorrect #405

Closed
bearner-hca opened this issue Sep 8, 2021 · 1 comment
Closed

Max error reported leaf pair incorrect #405

bearner-hca opened this issue Sep 8, 2021 · 1 comment

Comments

@bearner-hca
Copy link

Describe the bug
When using the Varian DICOM test file with induced error, we get the following image:
pf-image-truebeam-2021-01-18_2021-09-08_23a15a

However, the max_error_leaf pair is reported as 9, which is not correct as the leaf pair according to the image is 31 (Varian numbering) or leaf 20 (counting top to bottom of image). This seems to be a regression from previous versions (2.3.2) which reported the correct value?

To Reproduce
pip install pylinac

import pylinac
pf = pylinac.PicketFence("rtimage.dcm")
pf.analyze()
print(pf.max_error_leaf)

9

pip install pylinac==2.3.2

import pylinac
pf = pylinac.PicketFence("rtimage.dcm")
pf.analyze()
print(pf.max_error_leaf)

20

Expected behavior
Leaf pair 20 to be the maximum leaf error pair.

@jrkerns
Copy link
Owner

jrkerns commented Jun 21, 2022

Closed in v3.1, out soon

@jrkerns jrkerns closed this as completed Jun 21, 2022
jrkerns added a commit that referenced this issue Jun 24, 2024
Feature/RAM-3730 ROI samplers

Approved-by: Randy Taylor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants