Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundary check for pressure and p_tp. #415

Closed
peterg1t opened this issue Dec 8, 2021 · 2 comments
Closed

Boundary check for pressure and p_tp. #415

peterg1t opened this issue Dec 8, 2021 · 2 comments

Comments

@peterg1t
Copy link

peterg1t commented Dec 8, 2021

Describe the bug
Pressure value was not in the allowed range (90,115)

To Reproduce
Steps to reproduce the behavior:

  1. Run the test script with 89 kPa as a value for variable PRESS

Expected behavior
Pressure at our center hovers below the 90 kPa mark. This results in Ptp corrections larger than 1.1. This should be allowed as well (currently restricted to 0.9-1.1 range)

Screenshots
image

Additional context
Add any other context about the problem here.

@jrkerns
Copy link
Owner

jrkerns commented Dec 9, 2021

Duplicate of #353 . See here for how to change it: https://pylinac.readthedocs.io/en/latest/calibration_docs.html#changing-a-bound

Edit: In your case you'd change the MIN_PRESSURE constant

@peterg1t
Copy link
Author

peterg1t commented Dec 9, 2021

Thanks James. Closing this now!

@peterg1t peterg1t closed this as completed Dec 9, 2021
jrkerns added a commit that referenced this issue Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants