Update font-kit. #126
Merged
Update font-kit. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
commented
Apr 7, 2020
src/draw_target.rs
Outdated
| @@ -771,13 +773,15 @@ impl DrawTarget { | |||
| let bounds = font.raster_bounds( | |||
| *id, | |||
| point_size, | |||
| &fk::FontTransform::new(self.transform.m11, self.transform.m21, self.transform.m12, self.transform.m22), | |||
| &(self.transform.transform_point(*position)), | |||
| Transform2F::row_major(self.transform.m11, self.transform.m12, self.transform.m21, self.transform.m22, 0., 0.).translate(Vector2F::new(position.x, position.y)), | |||
There was a problem hiding this comment.
I honestly have no idea if this is the correct way to write this.
There was a problem hiding this comment.
Looks right to me. (BTW, master branch pathfinder_geometry has a vec2f() shortcut for Vector2F::new().)
jdm
commented
Apr 7, 2020
src/draw_target.rs
Outdated
| @@ -798,8 +802,7 @@ impl DrawTarget { | |||
| &mut canvas, | |||
| *id, | |||
| point_size, | |||
| &fk::FontTransform::new(self.transform.m11, self.transform.m21, self.transform.m12, self.transform.m22), | |||
| &position, | |||
| Transform2F::row_major(self.transform.m11, self.transform.m12, self.transform.m21, self.transform.m22, 0., 0.).translate(Vector2F::new(position.x, position.y)), | |||
|
font-kit 0.6 is now out. |
|
This is now in a state where it can be merged. |
|
Can this be updated to font-kit 0.7? |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't be merged until there's a new font-kit release, but I wanted to be sure that I don't lose these change.