Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibility testing for docs site (http://jrnl.sh) #1067

Merged
merged 1 commit into from
Oct 31, 2020

Conversation

wren
Copy link
Member

@wren wren commented Oct 29, 2020

This adds more work towards #1060. It wasn't originally listed in that issue, but #1061 pointed out an accessibility problem (low contrast) on the docs site. This pointed out that we don't currently test the docs site for accessibility, so that's what this PR adds.

It runs pa11y, and outputs the results in junit format (so that circle ci can show us the reports).

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@wren
Copy link
Member Author

wren commented Oct 29, 2020

Btw, we should set the accessibility tests to be required until all the issues are fixed. Which, uh, could be a while. 😬

Screen Shot 2020-10-28 at 5 26 31 PM

@wren wren added the build Issues related to the build pipeline label Oct 29, 2020
@wren wren changed the title add initial a11y config for docs site Add accessibility testing for docs site (http://jrnl.sh) Oct 29, 2020
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👓

@micahellison micahellison merged commit 57de3b7 into jrnl-org:develop Oct 31, 2020
@wren wren deleted the docs-site-a11y-1060 branch November 14, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants