Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog generation workflow to github actions #1086

Merged
merged 4 commits into from
Nov 21, 2020

Conversation

wren
Copy link
Member

@wren wren commented Nov 16, 2020

More work on #1060

This basically takes the exact script, and turns it into a workflow. The
only difference is that the new workflow doesn't detect a release build
like the script did (releases will be a separate workflow).

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

wren added 2 commits November 15, 2020 21:01
This basically takes the exact script, and turns it into a workflow. The
only difference is that the new workflow doesn't detect a release build
like the script did (releases will be a separate workflow).
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@micahellison micahellison added the build Issues related to the build pipeline label Nov 21, 2020
@micahellison micahellison merged commit e23c4b7 into jrnl-org:develop Nov 21, 2020
@github-actions
Copy link

Unit Test Results

  16 files  ±0    16 suites  ±0   9s ⏱️ -2s
280 tests ±0  280 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
281 runs  ±0  281 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

results for commit e23c4b7 ± comparison against base commit 8ec661b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants