Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to put --edit partly through a cli entry to move it to the editor #1091

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Add ability to put --edit partly through a cli entry to move it to the editor #1091

merged 1 commit into from
Nov 21, 2020

Conversation

wren
Copy link
Member

@wren wren commented Nov 21, 2020

Fixes #906

Also add some functionality to test suite to see what the editor file contents were and make assertions about it.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@wren
add ability to put --edit partly through a cli entry to move it to th…
01a0c48 
…e editor

also add some functionality to test suite to see what the editor file contents were and make assertions about it
@github-actions

This comment has been minimized.

Sign in to view
micahellison
micahellison approved these changes Nov 21, 2020
View reviewed changes
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝

@wren wren force-pushed the develop branch 2 times, most recently from 807e58e to 142e6f5 Compare November 21, 2020 23:08
@micahellison micahellison added the enhancement New feature or request label Nov 21, 2020
@micahellison micahellison merged commit cfdd053 into jrnl-org:develop Nov 21, 2020
@github-actions
Copy link

Unit Test Results

  16 files  ±  0    16 suites  ±0   10s ⏱️ -1s
284 tests +10  284 ✔️ +10  0 💤 ±0  0 ❌ ±0 
285 runs  +10  285 ✔️ +10  0 💤 ±0  0 ❌ ±0 

results for commit cfdd053 ± comparison against base commit 09cd77e

@wren wren deleted the edit-inline-906 branch November 28, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow --edit flag partway through an entry
2 participants
@wren @micahellison