Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a release workflow for PyPI in CI (Github Actions) #1095

Merged
merged 3 commits into from
Nov 28, 2020

Conversation

wren
Copy link
Member

@wren wren commented Nov 23, 2020

More work on #1060 (getting close to done!)

  • Support ci skip tag on commits to avoid build dupes
  • Add smarter path detection so we don't spam tons of tests
  • Allow steps to cancel if previous steps were cancelled (don't always
    run)
  • Separate workflows to be more modular
  • Update release workflow to do a few more things
  • Add helpful messages to workflows
  • Be more strict in version checking (now with added regex)
  • Make changelog smarter about when to trigger
  • Add some functionality for changelog to handle releases and
    prereleases separately
  • Better error handling
  • Split up the version validation and the release to make way for more
    releases

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

- Support ci skip tag on commits to avoid build dupes
- Add smarter path detection so we don't spam tons of tests
- Allow steps to cancel if previous steps were cancelled (don't always
  run)
- Separate workflows to be more modular
- Update release workflow to do a few more things
- Add helpful messages
- Be more strict in version checking (now with added regex)
- Make changelog smarter about when to trigger
- Add some functionality for changelog to handle releases and
  prereleases separately
- Better error handling
- Split up the version validation and the release to make way for more
  releases
@github-actions

This comment has been minimized.

@wren
Copy link
Member Author

wren commented Nov 23, 2020

When this gets merged, the last thing for #1060 will be the homebrew stuff.

@wren wren added the build Issues related to the build pipeline label Nov 23, 2020
@github-actions
Copy link

Unit Test Results

  16 files  ±0    16 suites  ±0   10s ⏱️ +3s
288 tests ±0  288 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
289 runs  ±0  289 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

results for commit 6c06ed4 ± comparison against base commit e3aa088

Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@micahellison micahellison merged commit 4cad215 into jrnl-org:develop Nov 28, 2020
@wren wren deleted the release-ci-1060 branch November 28, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants