Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small accessibility fixes for docs site #1122

Merged
merged 5 commits into from
Dec 19, 2020
Merged

Small accessibility fixes for docs site #1122

merged 5 commits into from
Dec 19, 2020

Conversation

wren
Copy link
Member

@wren wren commented Dec 19, 2020 •
edited
Loading

This PR is a small follow up after #1061, with a few small fixes.

This should bring the accessibility testing back into a passing state.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

micahellison
micahellison approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@micahellison micahellison added the documentation Improvements or additions to documentation label Dec 19, 2020
@micahellison micahellison changed the title Small fixes for docs site Small accessibility fixes for docs site Dec 19, 2020
@micahellison micahellison merged commit 861bf98 into jrnl-org:develop Dec 19, 2020
@wren wren deleted the docs-site-follow-up-1061 branch December 19, 2020 21:35
wren added a commit that referenced this pull request Dec 20, 2020
@wren
Small accessibility fixes for docs site (#1122)
6d339f4 
* remove old file that was only needed for gh-pages

* fix broken icons on docs home page

* add more contrast to twitter button hover state

* tweak non-accessible color to meet standard

* tweak non-accessible colors to meet standard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wren @micahellison