New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new date format (`--format date`) for heatmapping #1146

Merged

wren merged 13 commits into jrnl-org:develop from KarimPwnz:plugin-datecount

Jan 16, 2021

Contributor

KarimPwnz commented Jan 4, 2021 •

edited

Loading

This PR adds a date count export plugin, allowing termgraph heatmaps :

jrnl --export dates | termgraph --calendar

Closes #743.

Checklist

I have read the contributing doc.
I have included a link to the relevant issue number.
I have tested this code locally.
I have checked to ensure there aren't other open pull requests
for the same issue.
I have written new tests for these changes, as needed.
All tests pass.

KarimPwnz added 7 commits

January 4, 2021 02:37


          Create datecount plugin

654cc6f


          Fix plugin import

65e48c3


          Update datecount format

37fc6c7


          Create datecount test

7880fee


          Remove outdated comment

0eb20e4


          Remove unnecessary datecount export condition

7cd961d


          Update test config

bff9bb1

wren reviewed

View reviewed changes

jrnl/plugins/util.py Outdated Show resolved Hide resolved

wren reviewed

View reviewed changes

jrnl/plugins/util.py Outdated Show resolved Hide resolved

wren reviewed

View reviewed changes

jrnl/plugins/datecount_exporter.py Outdated Show resolved Hide resolved

wren reviewed

View reviewed changes

jrnl/plugins/datecount_exporter.py Outdated Show resolved Hide resolved

wren reviewed

View reviewed changes

features/format.feature Outdated Show resolved Hide resolved


          Move get_date_counts into DateCountExporter; misc changes

wren reviewed

View reviewed changes

features/format.feature Outdated Show resolved Hide resolved

KarimPwnz added 4 commits

January 5, 2021 00:10


          Use --format instead of --export in datecount test

1fdfa12


          Update datecount test to include configs

3de193b


          Better datecount test

15de4c5


          Remove old tests

4bf1da9

wren requested changes

View reviewed changes

jrnl/plugins/datecount_exporter.py Outdated Show resolved Hide resolved


          Change 'datecounts' to 'dates'

23eb082

wren approved these changes

View reviewed changes

Member

wren left a comment

Good points. Thank you!

wren added the enhancement label

wren changed the title ~~Add date count export plugin for heatmapping~~ Add new date format (--format date) for heatmapping

wren merged commit a6b828e into jrnl-org:develop

KarimPwnz deleted the plugin-datecount branch

January 16, 2021 22:56

wren mentioned this pull request

Habit Formation: Visualize days with no entry in a month #1255

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels