Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix homebrew release, add options for release pipeline #1154

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

wren
Copy link
Member

@wren wren commented Jan 17, 2021

This adds a fix so that the jrnl bot can open a PR as intended in the release pipeline.

It also adds some options to control the release pipeline a bit more (in case we need to retry, which we sometimes need to do).

Checklist

  • I have read the contributing doc.
  • [n/a] I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • [n/a] I have written new tests for these changes, as needed.
  • [n/a] All tests pass.

Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the new inputs.

@micahellison micahellison added the build Issues related to the build pipeline label Jan 17, 2021
@micahellison micahellison changed the title Fix homebrew release, add options for relase pipeline Fix homebrew release, add options for release pipeline Jan 17, 2021
@micahellison micahellison merged commit c06b5cf into jrnl-org:develop Jan 17, 2021
@micahellison micahellison deleted the brew-deploy-fix branch January 17, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants