Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow emoji in config file in Windows by always opening it as unicode #1313

Merged
merged 4 commits into from
Aug 21, 2021

Conversation

micahellison
Copy link
Member

@micahellison micahellison commented Jul 31, 2021

Fixes #1162. I forced utf-8 encoding on open, since apparently Python won't use that in Windows by default.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@micahellison micahellison changed the title Allow emojis in config file in Windows by always opening it as unicode Allow emoji in config file in Windows by always opening it as unicode Aug 17, 2021
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wren wren added the bug Something isn't working label Aug 21, 2021
@wren wren merged commit 050c17e into jrnl-org:develop Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Journals with emoji names can't be accessed on Windows
2 participants