Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when DayOne/directory journals have encrypt: true in config #1325

Merged
merged 10 commits into from
Aug 21, 2021

Conversation

micahellison
Copy link
Member

Relates to #1243 and is built off of #1315.

Right now jrnl is silently accepting the "encrypt: true" config values for directory and DayOne journals, even though it's not encrypting them. This warns the user about it.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@micahellison micahellison added the bug Something isn't working label Aug 21, 2021
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️

@wren wren merged commit fa146b1 into jrnl-org:develop Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants