-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add added option to _print_edited_summary #1366
Add added option to _print_edited_summary #1366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, thanks for this contribution! I'd love to see some tests with this, though I recognize that haven't written any tests for this in the past.
We have two methods for testing this that could be fine - the normal pytest unit tests in tests/unit, or the pytest-bdd tests in tests/bdd. You're welcome to take either approach.
And if you're not interested in adding that in, that's absolutely okay. Just please let us know so we can take that on.
Hi. Thanks for the welcoming response. Unfortunately, I'm not familiar with testing in python. I would love to learn. Please feel free to add anything to the pull request. I will take a look at the changes and use them as an example for future contributions. |
OK, I added in some BDD (Gherkin) tests, though I excluded DayOne since it has its own way of dealing with this issue, which I think is beyond the scope of the PR. I also ran into some cache issues (hence the failing tests in GitHub actions) but resolved them in #1373. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Fixes #1198. The summary used to show negative numbers when entries were added. There was also no option to show the added entries.
Checklist
for the same issue.