Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt for password change when using 'jrnl --encrypt' on already encrypted journal #1477

Merged
merged 11 commits into from
May 21, 2022
Merged

Prompt for password change when using 'jrnl --encrypt' on already encrypted journal #1477

merged 11 commits into from
May 21, 2022

Conversation

jonakeys
Copy link
Contributor

This PR addresses issue #1358 Using --encrypt on an already encrypted journal now warns the user the journal is already encrypted and prompts for creating a new password.
I also added a BDD test.

No config file changes were needed as far I can see. But I'm not sure if the BDD test is complete this way or if it should need to enter a new password and check if the password indeed changed on the re-encrypted journal.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for implementing the @todo test!

@wren wren linked an issue May 21, 2022 that may be closed by this pull request
@wren wren added the bug Something isn't working label May 21, 2022
@wren wren merged commit 663f151 into jrnl-org:develop May 21, 2022
@jonakeys jonakeys deleted the encpassprmpt1358 branch May 21, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jrnl --encrypt doesn't prompt me for password change
3 participants