Create folder if config ends with (back)slash #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1293_folderNotExists
micahellison
approved these changes
Jun 4, 2022
wren
approved these changes
Jun 4, 2022
micahellison
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Accidentally closed the previous pull request #1482, so here it is again.)
This PR fixes the issue #1293 When reading the config file, the code now checks if the path ends with a (back)slash and if so, calls the FolderJournal instead of the PlainJournal.
I also added a BDD test for this specific check. There was already a check for a non-existent directory, but didn't check if the path ended with a (back)slash.
Checklist
for the same issue.